Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of unimplemented points #40

Closed
wants to merge 3 commits into from
Closed

Add handling of unimplemented points #40

wants to merge 3 commits into from

Conversation

andig
Copy link
Contributor

@andig andig commented Jul 1, 2019 •
edited

Fixes #33.

BC break as behaviour changes. Might make sense to only apply this to ScaledValue instead of Value, too to limit the impact.

Open:

@jonseymour
Copy link
Collaborator

Please rebase onto master. I need to think about this one some more.

@andig
Copy link
Contributor Author

andig commented Jul 19, 2019 •
edited

Done. It think we need to decide:

  • does this need a type or is nil sufficient
  • where does this need to be implemented- all getters or value and/or scaled value
  • or an outside helper function instead part of the point
  • if this should also catch the acc type fields which I've skipped

@andig
Copy link
Contributor Author

andig commented Jul 31, 2019

ping @jonseymour anything I could do at this time?

@andig
Copy link
Contributor Author

andig commented Aug 13, 2019

Ping @jonseymour could we take this further? I really appreciate the exchange- would be great to keep it up!

@andig andig closed this Apr 29, 2020
@andig andig deleted the not-implemented branch April 29, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement handling of NaN values
2 participants
@andig @jonseymour