Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo deny #40

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: add cargo deny #40

merged 2 commits into from
Oct 5, 2023

Conversation

CrabNejonas
Copy link
Contributor

This PR adds cargo-deny as a CI check to ensure our dependency tree only contains MIT/Apache-2.0 compatible licenses.

I also ran cargo-deny as part of setting this up ofc and it seems good except for 3 questions we have to answer:

  • is BSD-3-Clause compatible with MIT/Apache-2.0?
  • is OpenSSL license compatible with MIT/Apache-2.0?
  • is Zlib license compatible with MIT/Apache-2.0?

@beanow-at-crabnebula
Copy link
Member

beanow-at-crabnebula commented Oct 5, 2023

I think OpenSSL/SSLeay, BSD and Zlib are fine to use as dependencies.

But zlib does put some limitations on modifying, so if we need to, I think we'll have to do a bunch of forking work to keep that contained.

Similarly the old OpenSSL/SSLeay license requires some notice, but can be used as dependency.

@CrabNejonas
Copy link
Contributor Author

But zlib does put some limitations on modifying, so if we need to, I think we'll have to do a bunch of forking work to keep that contained.

Zlib is only used in adler32 which I don't expect us to modify like ever, so that's fine

Similarly the old OpenSSL/SSLeay license requires some notice, but can be used as dependency.

Something we have to put into the readme or similar?

deny.toml Outdated Show resolved Hide resolved
@amr-crabnebula amr-crabnebula merged commit db1311d into main Oct 5, 2023
10 of 11 checks passed
@amr-crabnebula amr-crabnebula deleted the jonas/cargo-deny branch October 5, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants