Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidsynth produces harsh noise #158

Open
davidkant opened this issue Jan 16, 2019 · 1 comment
Open

Fluidsynth produces harsh noise #158

davidkant opened this issue Jan 16, 2019 · 1 comment

Comments

@davidkant
Copy link

Fluidsynth synthesis sometimes produces loud harsh noise. This happens when accidentally synthesizing midi pitches that are beyond the range of the chosen instrument. The result should be silent but, i'm guessing due to the normalization, this gets turned into pretty brutal noise.

The quickest fix would be implement Issue #151 Normalization by default and let the user deal with it. Although pretty-midi could also do a quick amplitude check before normalizing. Either is fine by me. Just trying to save my students' ears! Or really save them from getting upset with me...

Thank so much!
David

@craffel
Copy link
Owner

craffel commented Jan 16, 2019

PRs are welcome to resolve #151; I'd be happy to have normalization be via a kwarg which is set to False by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants