Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer from CP should be run with --no-scripts #3574

Closed
Saboteur777 opened this issue Dec 18, 2018 · 2 comments
Closed

Composer from CP should be run with --no-scripts #3574

Saboteur777 opened this issue Dec 18, 2018 · 2 comments

Comments

@Saboteur777
Copy link
Contributor

Saboteur777 commented Dec 18, 2018

Description

Composer from CP (eg. on plugin removal) should be run with --no-scripts, else it might end up in an error message, if the needed programs not found on the running host.

Steps to reproduce

  1. Add a post-update-cmd scipt to composer.json's scripts section, like this:
    "post-update-cmd": [
      "git commit composer.json composer.lock -m 'Craft and/or plugin updates'"
    ]
  1. Remove a plugin on a host where git is not installed.

Additional info

  • Craft version: 3.0.35
  • PHP version: 7.3.0
  • Database driver & version: MySQL 5.5.5
  • Plugins & versions:
    Bugsnag 2.0.1
    Cookies 1.1.11
    CP Element Count 1.0.1
    CP Field Inspect 1.0.5
    Environment Label 3.1.5
    Guest Entries 2.1.3
    Mailgun 1.3.0
    Mailgun Events 1.0.4
    Minify 1.2.9
    Notifications 1.1.1
    Redactor 2.1.7
    SEOmatic 3.1.36
    Splash 3.0.2
    Super Table 2.0.14
    Twig Profiler 1.0.0
@Saboteur777 Saboteur777 changed the title Running Composer from CP should be run with --no-scripts Composer from CP should be run with --no-scripts Dec 18, 2018
@brandonkelly
Copy link
Member

Agree. Done for today’s release.

@Saboteur777
Copy link
Contributor Author

Awesome, thanks for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants