Add element check for (global set) project config sync

[joshuabaker]

What happened

Project config sync failed to create a global set fully, setting the ID to a random element.

Why it happened

A field plugin threw an exception (during validation) inside the associated fieldset, which meant that the element save failed. This meant there was no ID for the globalset sync (below). The default globalset table auto increment was used, which caused an invalid reference to an element with the same ID.

cms/src/services/Globals.php

Lines 441 to 445 in a0ed3fb

	$elementsService->saveElement($element, false);
	// Save the volume
	$globalSetRecord->id = $element->id;
	$globalSetRecord->save(false);

How to fix it

I think we should introduce a check here to ensure that the element is saved.

$success = $elementsService->saveElement($element, false);

if (!$success) {
   throw new Exception('Could not save element when syncing global set.');
}

$globalSetRecord->id = $element->id;

Without looking, I suspect that this applies more broadly to project config syncing. This could’ve been rather messy had we not tested this a few times locally.

[andris-sevcenko]

Thanks for the tip! Fixed for the next release that should be out today!