Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Froala tables not displaying correctly #6219

Closed
jamiewade opened this issue Jun 15, 2020 · 2 comments
Closed

Froala tables not displaying correctly #6219

jamiewade opened this issue Jun 15, 2020 · 2 comments

Comments

@jamiewade
Copy link

Description

When using the Froala plugin, table previews in the Control Panel are not displaying correctly:

Screenshot_2020-06-15 Test Page - Southend-on-Sea Borough Council

This is caused by Craft's CSS here:

https://github.com/craftcms/cms/blob/develop/src/web/assets/cp/dist/css/_main.scss#L1604:L1609

Additional info

  • Craft version: Craft CMS 3.4.23
  • PHP version: 7.3.16
  • Database driver & version: MySQL 5.7.29
  • Plugins & versions: Froala 3.1.0
@brandonkelly
Copy link
Member

The fix for this would be a breaking change for all of the tables that are styled correctly via the current CSS, so not something we’d change until Craft 4. Froala should just override those CSS styles, alongside whatever other theme overrides they’ve made to make their field look good within Craft’s control panel.

@jamiewade
Copy link
Author

@brandonkelly No problem Brandon, I wasn't sure if this was something Craft could handle. I'll create an issue with Froala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants