Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users without delete entries permission can delete entries #7233

Closed
carlcs opened this issue Dec 7, 2020 · 6 comments
Closed

Users without delete entries permission can delete entries #7233

carlcs opened this issue Dec 7, 2020 · 6 comments
Labels
bug severity:normal Bugs that affect typical usage

Comments

@carlcs
Copy link
Contributor

carlcs commented Dec 7, 2020

Description

The user doesn’t have “Delete entries” permissions for a section. The “Delete entry” action shows on Edit Entry pages and on the Entry index page for that section (see related issue #7232), and clicking those does actually delete the entry.

The user does have the “Delete other authors’ entries” permission and the entry in question is actually created by another user. This shouldn’t be of relevance though as “Delete entries” should overrule “Delete other authors’ entries”.

Additional info

  • Craft version: 3.5.16
@carlcs carlcs added the bug label Dec 7, 2020
@brandonkelly brandonkelly added this to the 4.0 milestone Dec 12, 2020
@brandonkelly
Copy link
Member

The way the permissions are currently laid out, I’d say this is expected behavior. As you mentioned, the “Delete entries” permission is not a prerequisite for the “Delete other authors’ entries”.

User permissions for a section, showing that it’s possible to grant someone permission to delete other authors’ entries without having permission to delete entries in a general sense

Perhaps for Craft 4 we could come up with some way of establishing cross-hierarchical permission prerequisites, so if “Delete entries” isn’t checked, then “Delete other authors’ entries” is greyed out.

@brandonkelly brandonkelly added enhancement improvements to existing features user management 😇 features related to user management and removed bug labels Dec 12, 2020
@carlcs
Copy link
Contributor Author

carlcs commented Dec 12, 2020

So you’re saying „Delete entries“ basically means „Delete own entries“? Could you please name it like this then?

@carlcs
Copy link
Contributor Author

carlcs commented Dec 13, 2020

Does it work the same for „Publish live changes“? If this is unchecked and „Publish live changes for other authors entries“ is checked, the user can publish entries just not their own?

@carlcs
Copy link
Contributor Author

carlcs commented Dec 13, 2020

If you don’t want to rename these permission settings, can you please provide this information (setting can be overruled) in an info tooltip?

@brandonkelly brandonkelly added bug severity:normal Bugs that affect typical usage and removed enhancement improvements to existing features user management 😇 features related to user management labels Dec 14, 2020
@brandonkelly brandonkelly removed this from the 4.0 milestone Dec 14, 2020
@brandonkelly
Copy link
Member

Does it work the same for „Publish live changes“? If this is unchecked and „Publish live changes for other authors entries“ is checked, the user can publish entries just not their own?

Sorry, good point, it was not consistent with Edit or Publish permissions. So I do agree this is a bug, and have fixed for the next release.

@brandonkelly
Copy link
Member

Craft 3.5.17 is out now with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity:normal Bugs that affect typical usage
Projects
None yet
Development

No branches or pull requests

2 participants