Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightswitch field accessibility #7313

Closed
missmatsuko opened this issue Dec 21, 2020 · 0 comments · Fixed by #7315
Closed

Lightswitch field accessibility #7313

missmatsuko opened this issue Dec 21, 2020 · 0 comments · Fixed by #7315
Assignees
Labels
accessibility 👤 features related to accessibility bug

Comments

@missmatsuko
Copy link
Contributor

missmatsuko commented Dec 21, 2020

Description

Screenshot of 2 lightswitch fields.

  • The on/off text should not be label elements. The label above the lightswitch field should be its only label element, or else it's unclear which label will be announced for the input.

  • Add aria-describedby to describe how the checked status is related to the on/off labels.

  • The focus style is too subtle, but this should be a global fix.

  • the switch role doesn't support indeterminate/mixed values, so change to a checkbox which does

  • The indeterminate/mixed style looks very similar to the off style:
    Screenshot of lightswitch field in an indeterminate/mixed state.

  • Tangentially, the labels for the on/off fields on the field settings side seem like they shouldn't be uppercase:
    Screenshot of lightswitch field settings.

Steps to reproduce

  1. Look at a lightswitch field. E.g. "System Status" at admin/settings/general.

Additional info

  • Craft version: 3.5.17.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant