Some fields' select/input elements missing id attribute

[missmatsuko]

Description

Some fields' select/input elements missing id attribute, so their labels aren't linked up:

• select in dropdown field
• select in multi-select field
• input in number field

Steps to reproduce

1. Inspect the select/input in dropdown, multi-select, and number fields.

Additional info

• Craft version: 3.5.17.1

[brandonkelly]

This should be fixed in general as of Craft 3.5.13 thanks to d42c9b5. Where are you seeing missing id attributes?

[missmatsuko]

For example, on this dropdown field. The label has a for attribute of dropdown1, but there is no element on the page with an id of dropdown1. In this case, the <select> element should have this id attribute.

[brandonkelly]

Ahh, thanks! Just fixed that for the next release, for Dropdown, Multi-select, and Number fields.

I’ve also “fixed” it for Checkboxes and Radio Buttons fields for Craft 3.6, by having those field types start using <fieldset> + <legend>s rather than <div> + <label>s (341911b). (That change relied on the changes in fea2e21 to work, which is 3.6-only, so that’s why it wasn’t done for 3.5.x.)