Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired payment flash message #37

Closed
EmericW opened this issue Mar 15, 2022 · 1 comment
Closed

Expired payment flash message #37

EmericW opened this issue Mar 15, 2022 · 1 comment
Labels

Comments

@EmericW
Copy link

EmericW commented Mar 15, 2022

Description

After trying all the different Mollie test states, I noticed the expired transaction state does not receive a nice error message like the failed or canceled does.
Screenshot 2022-03-15 at 11 05 09

Steps to reproduce

  1. Go through the checkout flow until you're in the Mollie test UI.
  2. Choose the "Expired" option.
  3. The transaction message in the database is the stringified JSON response from Mollie. And consequently also inside the flash messages.

Additional info

After some digging in the source, I found the location where the message is transformed:

if (is_array($data) && !empty($data['status'])) {

I'm just not sure if there is a specific reason the expired state has not been added to this function.

  • Craft version: 3.7.36
  • PHP version: 7.2.5
  • Database driver & version: MySQL
  • Craft commerce version: 3.4.11
  • Craft commerce mollie version: 3.0.0
@EmericW EmericW added the bug label Mar 15, 2022
@nfourtythree
Copy link
Contributor

Hi @EmericW

Thank you for bringing this to our attention.

We have pushed up a fix for this and we will get releases out for both 3.x and 4.x versions of the plugins that include the update.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants