Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error Response on Offsite Complete Purchase Request #51

Closed
pdaleramirez opened this issue Feb 21, 2022 · 4 comments
Closed

Better Error Response on Offsite Complete Purchase Request #51

pdaleramirez opened this issue Feb 21, 2022 · 4 comments
Labels
💡 enhancement Ideas and suggestions

Comments

@pdaleramirez
Copy link
Contributor

What are you trying to do?
When PayPal encounters an error when submitting the payment request it throws PaymentException (

throw new PaymentException($e->getMessage());
) which creates a bad user experience.

What's your proposed solution?
It would be good to implement the craft\commerce\base\RequestResponseInterface same as how Commerce Stripe Implement returned errors

@pdaleramirez pdaleramirez added the 💡 enhancement Ideas and suggestions label Feb 21, 2022
@aeu
Copy link

aeu commented Feb 21, 2022

Hi Dale,

Thanks for taking a look at this, but respectfully, an eCommerce site throwing a Internal Server error on a card decline is not an enhancement, it's a critical issue. This is what our customers are seeing on card declines, which can happen for something as simple as a typo during checkout or hitting PayPal fraud protection.

craft-exception

PayPal in particular takes a very aggressive stance on fraud protection (as they should) and card declines are not uncommon at all. A card decline should not crash an eCommerce platform.

Note also that when this happens the customers cart is cleared. Also a critical issue.

@nfourtythree
Copy link
Collaborator

nfourtythree commented Feb 23, 2022

Hi @aeu

Thank you for your message and extra information.

We have just pushed up an update that will fix this issue. Error messages from the API will now be returned and the user will be redirected to the payment page.

This update will be included in the next release of the plugin.

Thanks.

@aeu
Copy link

aeu commented Feb 23, 2022

Hi @nfourtythree

This is excellent news, thank you!

Do you have a timeline for when that release will be?

@nfourtythree
Copy link
Collaborator

Hi @aeu

We have just published the 1.3.2 version of the plugin.

You will be able to update now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement Ideas and suggestions
Projects
None yet
Development

No branches or pull requests

3 participants