Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore sales when this discount is applied effects carts without the discount applied #1206

Closed
Tam opened this issue Jan 7, 2020 · 10 comments
Assignees
Labels

Comments

@Tam
Copy link

Tam commented Jan 7, 2020

Description

If I have a discount that has the Ignore sales when this discount is applied. enabled it will cause sales to be ignored regardless of whether or not the discount has been applied to the cart.

Steps to reproduce

  1. Create a sale
  2. Create a discount with Ignore sales when this discount is applied. enabled
  3. Add a product to your cart that is targeted by the sale
  4. Note that the price in the cart is now the original price, not the sale price.

Additional info

  • Craft version: Craft Pro 3.3.19
  • PHP version: 7.3.9
  • Database driver & version: PostgreSQL 11.5
  • Plugins & versions:
Plugin Version
Craft Commerce 2.2.13
@lukeholder
Copy link
Member

Can you please send your DB dump/backup to support@craftcms.com so we can try to reproduce? Thanks.

@lukeholder lukeholder added the 🔎 status: investigating Trying to reproduce label Jan 23, 2020
@Coalescent
Copy link

I've run into this behaviour as well (as documented here: https://craftcms.stackexchange.com/questions/33455/commerce-2-sales-not-present-in-cart-lineitems). I can send a db backup as well if needed.

@lukeholder
Copy link
Member

Please send a DB backup/dump, thanks.

@JustJarethB
Copy link

I also have this issue as documented here, I did not fully realise the cause before. The bug sprouted somewhere between 2.2.9 => 2.2.11
#1229

@Tam
Copy link
Author

Tam commented Jan 24, 2020

Sorry, I should have mentioned that this is re-creatable on a fresh install of Commerce (just tested using 2.2.14).

@lukeholder
Copy link
Member

lukeholder commented Jan 24, 2020

@Tam @JustJarethB @Coalescent Please can someone send a DB dump or backup so we can try to reproduce this issue and debug. Thanks. support@craftcms.com

@Coalescent
Copy link

I sent one last night to support and got a response from @angrybrad, so I assume someone on your end has it?

@angrybrad
Copy link
Member

angrybrad commented Jan 24, 2020

@Coalescent yup got it and assigned it to @lukeholder @nfourtythree just a few minutes ago

@lukeholder
Copy link
Member

Thanks for reporting. This has been fixed for the next release due out very soon.

@lukeholder
Copy link
Member

This is now fixed in Commerce 2.2.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants