-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShippingMethodOption error breaking checkout #1378
Comments
As @keyurshah states this is from 4f139cd and specifically 4f139cd#diff-a71a5371ab7c5db4ebcffcab49d15a0fR1573 where its using all the attributes in a shipping method class, and trying to set the respective attribute on the This issue with Postie, and I'm sure any other custom shipping method, is that there will almost certainly additional attributes on classes. Basically, it means we can't have any public attributes on the shipping method class that doesn't exist in the Probably needs to be smarter than Let me know if I should be doing something on Postie's end? Refer to verbb/postie#27 |
Yeah looks like a bug. Will fix shortly. |
This has been fixed for the next release. Thank you for bringing this to our attention. A fix has been pushed and will be included in the next release. To get this early, change your
Then run Thanks. |
@lukeholder Tested and working, nice one! |
@lukeholder Something seems to have changed to make this no longer work. Again, Postie provides its own This population of a new model is where things fall over. Because these new Might I recommend storing the shipping method that's being used to create the shipping method option? I know that one extends the other, but it doesn't factor in any third-party setups. $option->shippingMethod = $method; Or, maybe another approach is to add an event for us to hook into which is a before/after populate/create Lastly, we could try and figure out a way for Postie to implement it's own |
Description
It seems with the latest craft 3.1.1, an error is being caused during shipping calculation.
This error is critical and prevents adding to cart and checking out.
This error does not always occur though. It seems to happen when user is logged in.
We are using verbb/postie to handle shipping.
verbb/postie#27
It seems that it is with this commit
4f139cd
Steps to reproduce
Additional info
The text was updated successfully, but these errors were encountered: