Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration to not make a request related to sales for each variant in the detail of a product #1883

Closed
jlachancekffein opened this issue Nov 18, 2020 · 1 comment
Assignees

Comments

@jlachancekffein
Copy link

What are you trying to do?

In the administration panel, when viewing the detail of a product, a request is made for each variant in order to return the related sales.

This causes a problem when there are several variants for a single product.

Capture d’écran 2020-11-18 à 14 54 51

What's your proposed solution?
It would be interesting to have a configuration option to display or not this functionality.

For now, in order to work around the problem, I am getting each request to determine if it is a request with request queryParam ('p') === 'admin/actions/commerce/sales/get-sales-by-purchasable-id '.

If so, I directly return a void-type response to prevent sql query.

@lukeholder
Copy link
Member

This is now fixed in the latest release: 3.2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants