Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Unable to select categories for promotions after completing 'entrification' #3134

Closed
sunscreem opened this issue Apr 6, 2023 · 8 comments
Assignees
Labels
commerce5 💡 enhancement Ideas and suggestions

Comments

@sunscreem
Copy link

What happened?

Description

We've now moved all our categories into structures as per the Entrification blog so that we are ready for next version of Craft. This has meant product categories can no longer be selected.

Steps to reproduce

  1. Move all categories into structures.

Expected behavior

image

Actual behavior

When clicking the button it's empty.

Craft CMS version

4.4.5

Craft Commerce version

4.2.6

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@sunscreem sunscreem added commerce4 Issues related to Commerce v4 bug labels Apr 6, 2023
@pdaleramirez pdaleramirez added 💡 enhancement Ideas and suggestions and removed bug labels Apr 11, 2023
@pdaleramirez
Copy link
Contributor

@sunscreem Commerce will also get a new version to support “structures” on promotions.

@sunscreem
Copy link
Author

Awesome - thanks @pdaleramirez. Is that likely to be a 5.x release or a 4.x release?

@pdaleramirez
Copy link
Contributor

Awesome - thanks @pdaleramirez. Is that likely to be a 5.x release or a 4.x release?

It would be a 5. x release.

@lukeholder lukeholder added commerce5 and removed commerce4 Issues related to Commerce v4 labels Apr 12, 2023
@lukas-jansen
Copy link
Contributor

@pdaleramirez maybe this should be clearly noted somewhere.

We already started a new commerce project with only entries but now we have to restructure it back to categories as we didn't noticed this yet until now...

And luckily didn't migrated existing commerce projects over yet.

@lukeholder
Copy link
Member

@lukas-jansen

We've decided to add a setting to the next release of Commerce to switch sales to use entries for it's relationship condition.

Will update the progress here.

Thanks

@lukeholder lukeholder self-assigned this May 30, 2023
@WHITE-developer
Copy link

@lukeholder Any update on this in which release it would be in.

Starting another shop, so have to decide if we can go the full entry way or need to stick with the categories

@lukeholder
Copy link
Member

I was just finishing the feature up at the moment, and it will likely be in 4.3 but I can't give an accurate estimate on when that will be out just yet.

@lukeholder
Copy link
Member

This was completed in Commerce 4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce5 💡 enhancement Ideas and suggestions
Projects
None yet
Development

No branches or pull requests

5 participants