Hooking to Order::EVENT_AFTER_ORDER_PAID doesn't work

[Saboteur777]

Description

Trying to listening to Order::EVENT_AFTER_ORDER_PAID events, but the code attached to this event never runs.

Steps to reproduce

1. Example code:

<?php 

namespace webmenedzser\billingo;

use craft\commerce\elements\Order;

class Billingo extends Plugin
{
    public function init()
    {
        parent::init();
        self::$plugin = $this;

        $this->_registerTransactionEvents();
    }

    private function _registerTransactionEvents()
    {
        // This runs
        Event::on(
            Payments::class,
            Payments::EVENT_AFTER_CAPTURE_TRANSACTION,
            function(TransactionEvent $e) {
                // @var Order $order
                $order = $e->transaction->order;

                Craft::$app->queue->push(new CreateInvoice([
                    'order' => $order,
                ]));
            }
        );

        // This doesn't
        Event::on(
            Order::class,
            Order::EVENT_AFTER_ORDER_PAID,
            function(Event $e) {
                Craft::info(
                    'Order paid, event called',
                    __METHOD__
                );
            }
        );
    }
}

2. Initiating a payment via the CP, and capturing it doesn't fires the Order::EVENT_AFTER_ORDER_PAID event.

It might be that I should listen to multiple events for different payment methods, but that seems counter-intuitive.

Additional info

• Craft version: 3.3.4.1
• PHP version: 7.3.6
• Database driver & version:
• Plugins & versions: Commerce 2.1.13
• Video: https://drive.google.com/file/d/1rjlVjp2HLoyrCRgg22Y231NnOZMgmFFS/view

[lukeholder]

Does you order have a date paid after you refund them?

[Saboteur777]

No, it doesn't have (at least it is not shown in the sidebar).
With a completely new Order the event happened and the "Order paid,..." text ended up in the logs, so my question is: why the Order::EVENT_AFTER_ORDER_PAID event is not happening after a refund + new payment combination?

[lukeholder]

It is because the datePaid isn't unset on refund, so the new paid event isn't triggered. Will need to fix for next release.

[Saboteur777]

Thanks!

[lukeholder]

Fixed in e7f9569 will be in the next release.

[Saboteur777]

Thanks! Luke Holder <notifications@github.com> ezt írta (időpont: 2019. okt. 6., V, 1:58):

…

Fixed in e7f9569 <e7f9569> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1026?email_source=notifications&email_token=ACFELI37IPKLNJBCWSEHZETQNESZPA5CNFSM4I5BDURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAN6J6I#issuecomment-538699001>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACFELI5EBGJ3BYLVK4N4MFLQNESZPANCNFSM4I5BDURA> .

-- *dr. Radics Ottó* +36 20 923 8883 Webmenedzser.hu <http://webmenedzser.hu/?utm_source=signature&utm_medium=e-mail&utm_campaign=signature>

[kevinmu17]

Seems to be happening again in Commerce 3, I updated today and the event is not being called, neither is EVENT_AFTER_COMPLETE_ORDER

Other events like EVENT_AFTER_ADD_LINE_ITEM are working