Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not saving Entry Type to use when "Create entries if they do not exist" is checked for related entry fields. #1387

Closed
stevecomrie opened this issue Nov 28, 2023 · 7 comments
Assignees
Labels

Comments

@stevecomrie
Copy link

stevecomrie commented Nov 28, 2023

Description

It would seem that Feed Me is having a problem remembering which entry type you want to use when creating new records for related Entry fields.

The record I'm importing has a field named "topics".

"Topics" is an Entry field that only allows selections from the "Taxonomy" section.

"Taxonomy" has 3 different entry types.

When importing rows and choosing to add missing topic/taxonomy records, I can choose which Entry Type I want to use for creating new records.

The one I want to use is called "Private Tags"

image

If I choose anything other than the (default) first option, I can hit "Save & Continue", run the import, and everything works fine.

However, if I "Save" to reload the field-mapping page -- OR -- re-visit this page after having previously using "Save & Continue" -- the Entry Type selected defaults back to the first option in the dropdown and will silently overwrite the previous value on save.

image

So I don't think it's actually a "saving" problem, but rather a problem setting the selected attribute for on the proper item.

Steps to reproduce

  1. I think the above is pretty clear. But let me know if you need more info about anything.

Additional info

  • Craft version: 4.5.11
  • PHP version: 8.1
  • Database driver & version: MySQL
  • Plugins & versions:
@stevecomrie stevecomrie changed the title Not saving the Entry Type to use when create when Not saving Entry Type to use when "Create entries if they do not exist" is checked for related entry fields. Nov 28, 2023
@i-just i-just self-assigned this Dec 6, 2023
@i-just
Copy link
Contributor

i-just commented Dec 6, 2023

Hi, thanks for reporting! I raised a PR to fix this.

@flimshaw
Copy link

flimshaw commented Feb 7, 2024

@i-just thank you! i ran into this and it's really been slowing us down with imports. will try out the PR above

@harryfk
Copy link

harryfk commented Feb 21, 2024

Would be fantastic if this got merged/fixed – we’re currently running a larger import on a project and either we’re stuck until this is fixed or we need to convert entry types into individual sections. Doable, but not great. 😕

@flimshaw
Copy link

flimshaw commented Feb 21, 2024

Would be fantastic if this got merged/fixed – we’re currently running a larger import on a project and either we’re stuck until this is fixed or we need to convert entry types into individual sections. Doable, but not great. 😕

FWIW, until this is merged, it does seem like if you set a specific entry type in the current version of FeedMe, and hit 'Save and Continue' it will save it. But it is not properly resetting the dropdowns when you come back through, so you need to make sure they are reset everytime modifications are made to the field mapping.

Not ideal, but I definitely don't want to have to make a dozen new Sections either.

@harryfk
Copy link

harryfk commented Feb 22, 2024

@flimshaw Huh, I thought I tried that and it didn’t work, but I’ll check again. Thanks!

@angrybrad
Copy link
Member

Resolved in #1390 and will be included in the next release!

@harryfk
Copy link

harryfk commented Feb 26, 2024

Excellent, thank you so much! 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants