Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children of disabled parents will become orphaned #555

Closed
lindseydiloreto opened this issue Jun 13, 2019 · 4 comments
Closed

Children of disabled parents will become orphaned #555

lindseydiloreto opened this issue Jun 13, 2019 · 4 comments
Assignees
Labels

Comments

@lindseydiloreto
Copy link
Contributor

Description

If the parent category is disabled, Feed Me won't place the child category beneath it.

Instead, the child category will become orphaned, and pushed to the bottom of the list.

ORIGINAL SOURCE
Ω 2019-06-13 at 4 02 48 PM

IMPORT DESTINATION
Ω 2019-06-13 at 4 03 14 PM

Specifically, pay attention to the "Die Sets" and "Thermal Oxidizer" categories. You'll notice that they were not ported beneath their parent categories.

Instead, they were orphaned and dropped to the bottom of the list...
Ω 2019-06-13 at 4 03 52 PM

If you look at the feed, you'll notice that the feed is correct, and properly shows the intended parent category ID...
Ω 2019-06-13 at 4 18 06 PM

Steps to reproduce

  1. Create a source with nested categories. Disable some of the parent categories.
  2. Configure an import which copies the nested structure of your original categories.
  3. Run import feed.
  4. Notice that enabled parents get their correct children, but disabled parents do not. The children of disabled parents get orphaned, and shoved to the bottom.

Additional info

  • Plugin version: 4.1.0
  • Craft version: 3.1.30
@BenParizek
Copy link

We demand justice!

@lindseydiloreto
Copy link
Contributor Author

Do it for the children!

@angrybrad
Copy link
Member

@lindseydiloreto @BenParizek justice is slow, but always prevails.

Resolved in #1303 for the next v4 and v5 releases.

@angrybrad
Copy link
Member

We just released Feed Me 4.6.3. and 5.1.3 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants