Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Add site argument for remove command #320

Merged
merged 2 commits into from Apr 4, 2021

Conversation

mattstein
Copy link
Contributor

@mattstein mattstein commented Apr 3, 2021

Description

This makes it possible to skip the site prompt by passing an argument to nitro remove, consistent with other site-specific commands in the upcoming release.

Before

Argument still shows site prompt:

❯ nitro remove test.nitro
Select a site:
  1. craftcms.nitro
  2. europa.nitro
  3. starterblog.nitro
  4. test.nitro
  5. tutorial.nitro

After

Argument skips questioning. 😎

❯ nitro remove test.nitro
Removing test.nitro

@mattstein mattstein changed the base branch from main to develop April 3, 2021 15:37
@mattstein mattstein marked this pull request as draft April 3, 2021 15:38
@mattstein
Copy link
Contributor Author

Err, actually it works fine but displays the wrong hostname for Removing *.nitro. Gotta fix that.

Because accuracy matters.
@mattstein
Copy link
Contributor Author

We’re good again. Turns out simple derps translate into any programming language.

@mattstein mattstein marked this pull request as ready for review April 3, 2021 15:42
@mattstein mattstein changed the title Add site argument for remove command. Add site argument for remove command Apr 3, 2021
@jasonmccallister jasonmccallister merged commit 8bc0fe5 into develop Apr 4, 2021
mattstein pushed a commit to craftcms/docs that referenced this pull request Apr 5, 2021
@jasonmccallister jasonmccallister deleted the feature/remove-site-argument branch April 6, 2021 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants