Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Update npm and composer commands to use site containers #331

Closed
jasonmccallister opened this issue Apr 7, 2021 · 1 comment
Closed

Update npm and composer commands to use site containers #331

jasonmccallister opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels
enhancement Not really required but improves quality of life
Milestone

Comments

@jasonmccallister
Copy link
Member

jasonmccallister commented Apr 7, 2021

Description

Right now, both of the npm and composer commands create a temporary container based on the path of the command. This is useful for running these commands on directories that will never be related to a "site" in Nitro context. However, the 80 percent use case is to run npm or composer within the context of a site. Therefore these commands should be more "site aware" but fall back to a standalone container if it cannot determine the part is part of a site.

We need to update the commands to use the sites container as those containers now include node, npm, and composer by default.

@jasonmccallister jasonmccallister added the enhancement Not really required but improves quality of life label Apr 7, 2021
@jasonmccallister jasonmccallister added this to the 2.0.8 milestone Apr 7, 2021
@jasonmccallister jasonmccallister self-assigned this Apr 7, 2021
@jasonmccallister jasonmccallister removed this from the 2.0.8 milestone May 16, 2021
@jasonmccallister jasonmccallister added this to the 3.0 milestone Aug 5, 2021
@angrybrad angrybrad mentioned this issue Aug 30, 2021
Closed
@jasonmccallister
Copy link
Member Author

Hi, we are closing this issue as we have decided to retire Nitro, so no additional work will occur on this project. You can read the official blog post here https://craftcms.com/blog/retiring-craft-nitro. We appreciate everyones feedback and involvement and we look forward to refocusing our efforts on Cloud!

If you're looking for a new local development environment, we recommend DDEV and have a knowledge base article to help you with the transition: https://craftcms.com/knowledge-base/migrating-from-craft-nitro-to-ddev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Not really required but improves quality of life
Projects
None yet
Development

No branches or pull requests

1 participant