Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refHandle does not parse properly because of the dash #77

Closed
nichxlson opened this issue Aug 11, 2023 · 2 comments
Closed

refHandle does not parse properly because of the dash #77

nichxlson opened this issue Aug 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@nichxlson
Copy link
Contributor

nichxlson commented Aug 11, 2023

Description

Redactor plugin doesn't parse the refHandle because of the dash.

Steps to reproduce

  1. Add a link in a redactor field in this format: https://example.com#shopify-products:[id]@1:url and save the entry
  • The link doesn't parse and goes to example.com
  1. Change the refHandle field in elements/Product.php from shopify-products to shopifyproducts
  2. Change the link in redactor to https://example.com#shopifyproducts:[id]@1:url and save the entry
  3. The link now parses properly and when you make changes where the product URI is updated the redactor field link will also update

Additional info

  • Craft version: 4.4.8
  • PHP version: 8.0.28
  • Database driver & version: MySQL 8.0.27
  • Plugins & versions: Redactor 3.0.4 & Shopify 3.1.1
@nichxlson nichxlson added the bug Something isn't working label Aug 11, 2023
@lukeholder
Copy link
Member

lukeholder commented Nov 2, 2023

This has been fixed for the next release here: 9c74fb8. The ref handle has been changed to shopifyproduct. Will update this issue once 4.0 is out. Thanks.

@lukeholder
Copy link
Member

4.0.0 is now out. Make sure to read the changelog item to learn what you need to do to upgrade. The readme also contains instructions.

@lukeholder lukeholder reopened this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants