New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio] Create Site with Git Repo code quality #1758

Closed
RLChris-Lim opened this Issue Jan 12, 2018 · 3 comments

Comments

@RLChris-Lim

RLChris-Lim commented Jan 12, 2018

Code revisions

  1. debug logs for happy case for createSitePushToRemote (logger exists for clone, but not push)
  2. createSiteCloneRemoteGitRepo and createSitePushToRemote return booleans regarding whether they are successful or not, but method that calls them, createSiteWithRemoteOption doesn't use them, and only returns void. the groovy script doesn't make use of it either, so as long as the createSiteWithRemoteOption returns properly, the response will always be "OK"
@sumerjabri

This comment has been minimized.

Show comment
Hide comment
@sumerjabri

sumerjabri Jan 12, 2018

Member

Please add debug logs for happy path.
Please add exceptions/flow back to the API to support the exceptions detailed in the spec: http://docs.craftercms.org/en/3.0/developers/projects/studio/api/site/create-site.html

Member

sumerjabri commented Jan 12, 2018

Please add debug logs for happy path.
Please add exceptions/flow back to the API to support the exceptions detailed in the spec: http://docs.craftercms.org/en/3.0/developers/projects/studio/api/site/create-site.html

@dejan-brkic

This comment has been minimized.

Show comment
Hide comment
@dejan-brkic
Member

dejan-brkic commented Jan 17, 2018

@dejan-brkic dejan-brkic moved this from Backlog to Test & Validate in Crafter CMS v3.0.x Jan 17, 2018

@RLChris-Lim

This comment has been minimized.

Show comment
Hide comment
@RLChris-Lim

RLChris-Lim Jan 19, 2018

verified change

RLChris-Lim commented Jan 19, 2018

verified change

Crafter CMS v3.0.x automation moved this from Test & Validate to Completed Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment