Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][studio] Inject element's source descriptor during merging #4093

Closed
3 of 4 tasks
sumerjabri opened this issue May 28, 2020 · 9 comments
Closed
3 of 4 tasks

[core][studio] Inject element's source descriptor during merging #4093

sumerjabri opened this issue May 28, 2020 · 9 comments

Comments

@sumerjabri
Copy link
Member

sumerjabri commented May 28, 2020

Merged artifacts must include an element attribute indicating the source descriptor if different than the descriptor being loaded (think inheritance).
The attribute name is: src

  • Update Core
  • Update Engine
  • Update Studio
  • Update ICE to become aware of src element and leverage it to better author
@sumerjabri sumerjabri added this to the Crafter CMS v3.2.0 milestone May 28, 2020
@sumerjabri sumerjabri changed the title [core] Inject element's source descriptor during merging [core][studio] Inject element's source descriptor during merging May 29, 2020
@jdrossl jdrossl added this to In Progress in Crafter CMS v4 Aug 25, 2020
@jdrossl jdrossl moved this from In Progress to Backlog in Crafter CMS v4 Aug 25, 2020
@jdrossl jdrossl moved this from Backlog to In Progress in Crafter CMS v4 Aug 25, 2020
@jdrossl jdrossl moved this from In Progress to Test & Validate in Crafter CMS v4 Sep 8, 2020
@jdrossl
Copy link
Member

jdrossl commented Sep 9, 2020

@rart the new API for studio is ready

@jdrossl jdrossl assigned rart and unassigned jdrossl Sep 9, 2020
@sumerjabri sumerjabri added triage Requires triage priority: low and removed priority: medium triage Requires triage labels Sep 21, 2020
@rart
Copy link
Member

rart commented Oct 12, 2020

@jdrossl

  • Can't find this on swagger?
  • Is it possible to send flatten=false through the studio API? Can we propagate the options to the engine API?

@jdrossl
Copy link
Member

jdrossl commented Oct 12, 2020

@rart the docs have been updated:

for all of them the parameter is optional and false by default

@rart
Copy link
Member

rart commented Oct 12, 2020

@sumerjabri we didn't include the flatten option on the studio side. This disables the possibility of doing progressive loading of the content items.

PageBuilder is covered as this, by default, returns the whole content tree flattened but Form engine would benefit from the reduced/progressive on-demand payload. Also, since this is published as part of the npm studio-ui package, having the option provides additional versatility for the community to create (e.g. studio plugins) in whatever way it fits best for their use case.

I don't see value in hiding the option.

Can we include it?

@sumerjabri
Copy link
Member Author

sumerjabri commented Oct 13, 2020

@rart yes
@jdrossl please make flattening optional. @rart is saying that it's permanently on right now for Studio's version of this API.

@sumerjabri sumerjabri assigned jdrossl and unassigned rart Oct 13, 2020
@rart
Copy link
Member

rart commented Oct 15, 2020

As an additional item, please add an attribute containing the content type id of the source file: crafter-source-content-type-id). For example:

<header_o 
  crafter-source="/site/website/crafter-level-descriptor.level.xml"
  crafter-source-content-type-id="/component/level-descriptor"
>
    <item>
      ...

@sumerjabri
Copy link
Member Author

@jdrossl please work on this after CLI and then assign back to @rart

@rart this remains a low priority ticket from your perspective

@jdrossl
Copy link
Member

jdrossl commented Oct 19, 2020

@rart both updates are merged now

@jdrossl jdrossl assigned rart and unassigned jdrossl Oct 19, 2020
@rart
Copy link
Member

rart commented Jan 13, 2021

PageBuilder's ICE now recognizes inherited zones and allows editing the level descriptor.

@rart rart closed this as completed Jan 13, 2021
Crafter CMS v4 automation moved this from Test & Validate to Completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crafter CMS v4
  
Completed
Development

No branches or pull requests

3 participants