Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Retaining does not work with modded Signs #33

Open
Dekamir opened this issue Jun 21, 2023 · 2 comments
Open

Sign Retaining does not work with modded Signs #33

Dekamir opened this issue Jun 21, 2023 · 2 comments

Comments

@Dekamir
Copy link

Dekamir commented Jun 21, 2023

Signs added by mods, such as Ecologics, Farmer's Delight, Terrestria, Traverse, Cinderscapes, Improved End do not support Sign Retaining. Rest of the features seem to work.
An item/block whitelist option might be needed to avoid manually supporing every single mod.

@craftycorvid craftycorvid added enhancement New feature or request Mod Compatibility and removed enhancement New feature or request labels Jun 21, 2023
@HB-Stratos
Copy link

This would be quite nice to have for a modpack I am building right now. the mod https://modrinth.com/mod/signoddities can do this already (tested for farmers delight signs). It even works from vanilla to FD and back, though it can't do colors.
It would be nice to have this functionality ported over.

@craftycorvid
Copy link
Owner

The main issue with supporting content mods is that they don't tend to keep up with Minecraft updates, but rather stick to a single version for a long time. I'm currently maintaining this mod on the latest version of Minecraft at any given time, so adding explicit compatibility for other mods gets tricky when I go to update to a new version and they have no plans to do so.
I try to make the implementation of features as generic as possible so most things will work with modded signs out of the box. In the case of Sign Retaining, it currently relies on loot tables for saving the text and a crafting recipe for resetting the signs. I'm not aware of a way to implement that in a generic way, but maybe I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants