Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line ends are broken when template html is minimized for <script> tag #29

Closed
kuceram opened this issue Mar 4, 2016 · 6 comments
Closed
Milestone

Comments

@kuceram
Copy link

kuceram commented Mar 4, 2016

Having following code:

<div>
   some content
</div>
<script type="text/ng-template" id="myTemplate.html">
   <div>
      test
   </div>
</script>

is compressed to:
<div>some content</div><script type="text/ng-template" id="myTemplate.html"> n<div> n test n n </div> n</script>

I found some similar issues of the past...
#7
#11

@craigburke
Copy link
Owner

@kuceram you're using Windows, right? I think I know what the problem is here.

@craigburke
Copy link
Owner

This should be resolved in the latest version 2.3.0 feel free to reopen if I'm wrong.

@kuceram
Copy link
Author

kuceram commented Apr 6, 2016

This is still an issue. I don't use windows (I have Mac) but I use editor config which sets the line ends to LF. Btw. I don't probably have rights for reopening this issue...

@craigburke craigburke reopened this Apr 6, 2016
@craigburke
Copy link
Owner

@kuceram ok that's helpful. I'll take a look.

@craigburke craigburke added this to the 2.3.0 milestone Oct 25, 2016
@craigburke
Copy link
Owner

@kuceram take a look at version 2.4.0 just released and take a look at the new preserveLineBreaks property it should address your issue.

@passionfruit18
Copy link

Have you pushed this to the grails plugin repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants