Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct comment type not supported #5

Open
andyjeffries opened this issue Sep 1, 2023 · 2 comments
Open

Correct comment type not supported #5

andyjeffries opened this issue Sep 1, 2023 · 2 comments

Comments

@andyjeffries
Copy link

I've been a huge pusher for having "MARK" comments in VS Code, it's been raised as a PR now, but I noticed it doesn't work with ERB files using your extension.

The author of the extension says it's because the ERB comments (either <!-- ... --> for normal HTML comments or <%# ... %> for ERB ones aren't set as the comment formats in the extension.

microsoft/vscode#190759 (comment)

Any chance you could fix this so when the VS Code PR is merged, it works with ERB files too? One of the current ones /* ... */ isn't even valid Ruby/HTML-ERB?

Many thanks for your consideration (and thanks in general for the extension!)

@craigmaslowski
Copy link
Owner

Thanks for the PR, but this extension has been deprecated for a while now. I’d suggest using the actively maintained Rails extension, which has proper support for comments, instead.

@andyjeffries
Copy link
Author

Sorry about that, I'm actually using the ruby-lsp extension, but still had yours installed. Thanks for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants