Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSCS #9

Closed
GaryJones opened this issue Nov 17, 2016 · 2 comments
Closed

Remove JSCS #9

GaryJones opened this issue Nov 17, 2016 · 2 comments
Assignees
@craigsimps
Labels
Status: Accepted Type: Enhancement
Milestone
2.0.0

Comments

@GaryJones
Copy link
Contributor

JSCS is now end of life, and with #2 having implemented ESLint, there should be no reason to continue to include JSCS.

Removing it sooner, and bumping the major version number to indicate breaking compatibility, is likely to be far less painful than doing it later.
@craigsimps craigsimps added this to the 2.0.0 milestone Nov 17, 2016
@craigsimps
Copy link
Owner

Yes, I would agree. With ESLint in place and using the shared WP config (as in #2), it can be removed.

@craigsimps
Copy link
Owner

Closing this issue, JSCS was removed in commit 3a12406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigsimps craigsimps

Labels
Status: Accepted Type: Enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@GaryJones @craigsimps