Add unit tests for Version 1.0.0 release #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete all unit tests for values.py Fix unit tests for calculating offsets in expressions. Fix error with division in expressions. Move IO and error printing out of lower level classes. Fix for statement parsing - should be catching OperandTypeError Catch and raise ParseError instead of OperandTypeError. Catch all Exception errors and raise them during translation. Add negative PCR 16-bit offset test. Add unit tests for version 1 release. Refactor virtual file support for easier testing. Attempt to cover all of CassetteFile class. Refactor cassette and binary files to be inherited container classes. Move unit tests into proper packages. Add unit tests for CoCoFile objects. Add unit tests for SourceFile objects. Update assembler so it can produce binary files. Update file_util with new virtual file structures. Add missing test for BinaryFile objects.
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 82.55% 90.25% +7.70%
==========================================
Files 11 15 +4
Lines 1536 1581 +45
==========================================
+ Hits 1268 1427 +159
+ Misses 268 154 -114
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several new unit tests to cover various aspects of the code base that do not have proper unit tests. Significantly, this PR refactors many error handling routines, and pushes them up to outer classes to handle more cleanly. This PR also separates out I/O functions from the assembly routines, so that only data buffers are passed from object to object (this makes for simpler unit testing). Additionally,
VirtualFileclasses were overhauled, with a newVirtualFileContainerclass introduced to distinguish between various container types such as cassette images, disk images, hard disk images, etc. Unit tests are still missing onsource_file.pyandvirtual_file.pyas the issue #6 will involve further modification of those files to implement virtual disk access and manipulation. This PR closes #69