Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add semgrep rule to ensure we are using fd_cache for file handling #233

Open
indecisivedragon opened this issue Mar 5, 2024 · 0 comments
Labels
infrastructure Infrastructure-related tasks

Comments

@indecisivedragon
Copy link
Contributor

a few issues (ex: #225) have come up due to improper file handling

In chalk, we should always be using the fd_cache api to handle files, since it ensures that opened files are actually closed later so that we don't stall on too many files open or try to read from a closed file. To ensure that fd_cache is used, we should set up semgrep with a custom rule to check for the usage of other nim file handling and complain if detected.

@indecisivedragon indecisivedragon added the infrastructure Infrastructure-related tasks label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure-related tasks
Projects
None yet
Development

No branches or pull requests

1 participant