Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consider making path ignoring more robust #255

Open
ee7 opened this issue Mar 22, 2024 · 0 comments
Open

ci: consider making path ignoring more robust #255

ee7 opened this issue Mar 22, 2024 · 0 comments
Assignees

Comments

@ee7
Copy link
Contributor

ee7 commented Mar 22, 2024

I'm creating an issue to track what I mentioned in this comment, since the failure mode just happened.

PR #254 passed checks at PR time and on main, but only because the tests workflow was skipped (the Dockerfile was not included in the list of paths for which the workflow should run). It's easy to miss that a workflow was skipped when creating or reviewing a PR, so it then caused CI failures in subsequent PRs.

I argue that it is difficult to maintain a list of paths on which a workflow should run, and more robust to maintain a list of paths on which the workflow should not run.

It is better for a workflow to run on a PR when it doesn't need to, than not run on a PR when it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant