-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotated github ci output #778
Comments
We had annotations in the past. I'm assuming they aren't working. We were using json output for it https://github.com/crate-ci/typos/blob/master/action/entrypoint.sh#L64 I think I'd prefer using json over a problemMatch Alternatively, there is also #594 |
Oh! Yeah, I haven't seen it. I can take a look at fixing that instead then. |
Just checked - the output looks just fine to me. I think the "problem" is that the warnings that |
For most projects I've been on, we've preferred to not touch unrelated code in the review but to save those for another PR. This means annotating code unrelated to the PR is unactionable. By providing unactional annotations, we are creating extra noise for people that would make them more likely to ignore all annotations or turn off the tool. Unless there is additional information, then I'm going to assume the annotations are working as expected, that we don't want to expand the scope of the annotations, and for any further change in this area, we'd more likely want #594, I'm leaning towards closing this. |
Appreciate the consideration! Thanks for your input. |
It would be great to get typos annotated as part of a PR check. The most straightforward path is probably through a problem matcher - it could look something like this:
Happy to open a PR if it is desired!
The text was updated successfully, but these errors were encountered: