Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility of invoice cancellation (negative amounts in invoice) #597

Open
lowbits opened this issue Nov 12, 2021 · 14 comments
Open

Add possibility of invoice cancellation (negative amounts in invoice) #597

lowbits opened this issue Nov 12, 2021 · 14 comments

Comments

@lowbits
Copy link

lowbits commented Nov 12, 2021

Is your feature request related to a problem? Please describe.
Enter possibility of negative bills.
When an already paid invoice, is canceled. It must be possible to create a new invoice with a credit note. But the credit note is negative. Currently it is not possible to enter negative totals.

Describe the solution you'd like
Possibility of negative invoices

Describe alternatives you've considered
Automatically cancel invoices, which then create a credit note in the system with reference to the invoice number and invoice date.

@RobinDev
Copy link
Contributor

Duplicate #110 still relevant in 2022. Can we add this in the roadmap ?

I can't promise but i will try to make a PR before march.

@Ubiquitous-X
Copy link

This is the feature needed for me to use Crater. Very nice software, but can't use it in my business because of not being able to add items with negative prices. An implementation of this would be lovely.

@JoeyJanson
Copy link

Duplicate #110 still relevant in 2022. Can we add this in the roadmap ?

I can't promise but i will try to make a PR before march.

@RobinDev did you start on this already? could you share something already? Maybe I could have a look with you too. This is also a feature for me that's needed to use crater.

Thanks in advance!

@lowbits
Copy link
Author

lowbits commented Aug 3, 2022

Would also be interested in the progress, if not maybe; i will find some time 🤙

@JoeyJanson
Copy link

I've started working on this and will create a proof of concept. I will share some work soon; maybe you could hook on and/or review it @lowbits

@lowbits
Copy link
Author

lowbits commented Aug 13, 2022

@JoeyJanson yes, i would love to have a a look :)

@albertvisuals
Copy link

+1 We need this as well in order to be able to use crater.

@lowbits
Copy link
Author

lowbits commented Sep 14, 2022

@JoeyJanson can we help you out in a way? :)

@albertvisuals
Copy link

Are there any news on this matter?

@JoeyJanson
Copy link

JoeyJanson commented Dec 19, 2022

Sorry, took a little while before I could start on this again. Created a PR. Let me know your thoughts!

This is a working proof of concept. Since the column in the database can't be negative this should be the way to go in my opinion. Please let me know your thoughts on this. The front end probably needs some rework but that is not my strong side.

If you're still interested @lowbits please check it out.

@blanc6
Copy link

blanc6 commented Jun 21, 2023

Is there any news on this subject?
I've seen that you can put negative unit amounts on invoices to "force" a negative invoice. But there's a bug with the number of 00s.

@JoeyJanson
Copy link

Is there any news on this subject? I've seen that you can put negative unit amounts on invoices to "force" a negative invoice. But there's a bug with the number of 00s.

@ggiak did not like the idea to "use" invoices as credit invoice but would rather create a new super category to have this feature specific for credits. You can read my response in the PR but I did not get any answer to the question if there are any plans to work on the new credit category.

I'm using the changes from my PR myself and it works fine though..

And I'm not so sure if there is any real major development going on for this project. In discord I've seen some messages about "legacy maintenance only". I would love to contribute to improve and develop new features but there is not so much communication about where they (whoever "they" are right now) are heading, what the blocking issues are, where the code effort needs to be etc. Guess they are busy with other stuff (paid cloud solution which makes money of course) as I can understand but it is a bit of a shame since the application in the basis is good.

@ggiak
Copy link

ggiak commented Jun 28, 2023

Hey @JoeyJanson, I don't have a strong opinion to have the feature in the same category or not.

just to be able to keep a track on "refunds" when it comes to different people handling.

Let me know if you need any assistance on testing your pull request, looks lovely :)

@lowbits
Copy link
Author

lowbits commented Jul 3, 2023

Hey, i guess like @JoeyJanson this repository is dead. So maybe not ideal to create new features here.
Maybe we will create a fork and add their our logic.
Currently you cannot install crater with php 8.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants