Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaidLevelDomain code doesn't handle newer suffixes properly #183

Closed
kkrugler opened this issue Oct 27, 2017 · 2 comments
Closed

PaidLevelDomain code doesn't handle newer suffixes properly #183

kkrugler opened this issue Oct 27, 2017 · 2 comments
Assignees
@kkrugler

Comments

@kkrugler
Copy link
Contributor

Currently the PaidLevelDomain code has its own list of country codes, etc. In reality it should leverage the EffectiveTldFinder class, and add one more piece from the hostname to whatever that returns.

It will still likely need special casing for IP addresses, punycode-encoded URLs, etc but this would be more correct than what we've got currently.
@kkrugler
Copy link
Contributor Author

For example, this will fail:

assertEquals("fi.com", PaidLevelDomain.getPLD("www.fi.com"));

@kkrugler kkrugler self-assigned this Oct 27, 2017
@kkrugler
Copy link
Contributor Author

kkrugler commented Nov 5, 2017

Done

@kkrugler kkrugler closed this as completed Nov 5, 2017
@sebastian-nagel sebastian-nagel mentioned this issue Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkrugler kkrugler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkrugler