Remove Tika dependency #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnioche
reviewed
Mar 28, 2018
| } | ||
| throw new UnknownFormatException("Can't parse a gzipped sitemap with the embedded MediaType of: " + embeddedType + " (at: " + url + ")"); | ||
| } catch (Exception e) { | ||
| String msg = String.format("Failed to detect embedded MediaType of gzipped sitemap '%s'", url); |
There was a problem hiding this comment.
use explicit locale?
The forbidden API complains otherwise
[ERROR] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
[ERROR] in crawlercommons.sitemaps.SiteMapParser (SiteMapParser.java:232)
[ERROR] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
[ERROR] in crawlercommons.sitemaps.SiteMapParser (SiteMapParser.java:237)
sebastian-nagel
approved these changes
Mar 29, 2018
|
Sorry, you can call me a fool but I've run the large tests on the wrong version of crawler-commons (didn't update the dependency to 0.10-SNAPSHOT). There are a couple of regressions, but nothing serious. Opened #200 to fix these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt at replacing Tika-based mime-type detection with simple code.
I assume that sitemaps are UTF-8, thus no need to handle UTF-16LE/BE encoded BOMs when detecting patterns.