Make RobotRules accessible #134 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes SimpleRobotRulesParser._rules property protected and adds getters for SimpleRobotRulesParser._rules and RobotRules's properties - Changes SimpleRobotRulesParser return type from BaseRobotRules to SimpleRobotRules to allow access to concrete class without nasty type casts while still obeying super class contract
kkrugler
reviewed
May 14, 2018
CHANGES.txt
Outdated
| @@ -13,6 +13,7 @@ Current Development 0.10-SNAPSHOT (yyyy-mm-dd) | |||
| - Handle new suffixes in PaidLevelDomain (kkrugler) #183 | |||
| - Remove Tika dependency (kkrugler) #199 | |||
| - Improve MIME detection for sitemaps (sebastian-nagel) #200 | |||
| - Make RobotRules accessible #134 | |||
There was a problem hiding this comment.
Make RobotRules accessible (aecio via kkrugler) #134
kkrugler
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adds getters for SimpleRobotRulesParser._rules and
RobotRules's properties
to SimpleRobotRules to allow access to concrete class without
nasty type casts while still obeying super class contract