Sitemap index: stop URL at closing </loc> #227
Conversation
- at start of a <loc> element auto-close any unclosed <sitemap> element and add the sitemap if there is a valid URL from the previous <loc> element
| maybeAddSiteMap(); | ||
| return; | ||
| } | ||
| loc = new StringBuilder(); |
There was a problem hiding this comment.
Wouldn't you want to always reset loc, regardless of whether localName is loc or sitemap?
There was a problem hiding this comment.
If the start element holds an attribute (e.g., <lastmod>) the content of loc is still required. An example:
<sitemapindex>
<sitemap>
<loc>http://www.example.com/sitemap1.xml.gz</loc>
<lastmod>2004-10-01T18:23:17+00:00</lastmod>
<sitemap>
<loc>...
At second opening <sitemap> we can be sure that the previous sitemap is finished. But at the opening <lastmod> we need to wait for the modification date of the sitemap before we can call maybeAddSiteMap().
| return; | ||
| } | ||
| loc = new StringBuilder(); | ||
| if ("url".equals(localName)) { |
There was a problem hiding this comment.
Would this code ever get triggered, given the && ("loc".equals(localName) || "sitemap".equals(localName) clause above?
There was a problem hiding this comment.
Also, is there a way to unit test the reason why we want to do this reset of attributes?
There was a problem hiding this comment.
get triggered
Right, my fault. Should be "sitemap".equals(localName) - a copy-paste error when copying from XMLHandler. I'll also add a unit test regarding resetting the attributes.
- bug fix: <sitemap> element is closed, not <url> - add unit test to cover resetting of attributes
|
Thanks, @kkrugler! |
sebastian-nagel
deleted the
cc-213-auto-close-sitemap-in-sitemapindex
branch
(fixes #213)
At start of a
<loc>element auto-close any "unclosed"<sitemap>element and add the sitemap if there is a valid URL from the previous<loc>element.