[Sitemaps] Trim Unicode whitespace around URLs, fixes #224 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrugler
reviewed
Dec 13, 2018
| * Check whether character is any Unicode whitespace, including the space | ||
| * characters not covered by {@link Character#isWhitespace(char)} | ||
| */ | ||
| public static boolean isWhitespace(char c) { |
There was a problem hiding this comment.
Weren't here other places in the code calling Character.isWhitespace() that we'd want to change to using this routine? E.g. there was the other PR where the text being collected is checked to see if it's all whitespace. And if so, maybe it should go into a different class (not sure what string/char-ish utils we've got already).
kkrugler
reviewed
Dec 13, 2018
sebastian-nagel
force-pushed
the
cc-224-sitemaps-trim-unicode-whitespace
branch
from
8025cc0
to
67db8bf
Compare
|
Hi @kkrugler, updated the PR, rebased to current master, added changelog entry. All occurrences of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim all Unicode white space from URLs in sitemaps, sitemap indexes and feeds.