Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create external_service parameter #28

Merged
merged 4 commits into from Sep 27, 2017

Conversation

dhollinger
Copy link
Member

Added an external_service boolean parameter for allowing puppet-rsyslog to manage configs/logs shared with other processes that may be managed by other modules.

The most common example would be if someone is using garethr-docker to create and manage an rsyslog docker container and crayfishx-rsyslog to manage configuration that is shared with the container via a volume.

In this example, garethr-docker generates a service file (upstart, init.d, or systemd) that will stop/start the container as though it were a service. As rsyslog requires a stop/start to read configuration changes, allowing this module to set an externally managed service that crayfishx-rsyslog can notify on configuration changes is not only extremely helpful, but almost required.

external_service is a boolean that defaults to false, MUST be used in conjunction with service_name, and CANNOT be used with manage_service.

@crayfishx crayfishx added accepted enhancement New feature or request labels Sep 27, 2017
@crayfishx crayfishx merged commit 327ea3a into voxpupuli:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants