Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
external_service
boolean parameter for allowing puppet-rsyslog to manage configs/logs shared with other processes that may be managed by other modules.The most common example would be if someone is using
garethr-docker
to create and manage an rsyslog docker container andcrayfishx-rsyslog
to manage configuration that is shared with the container via a volume.In this example,
garethr-docker
generates a service file (upstart, init.d, or systemd) that will stop/start the container as though it were a service. As rsyslog requires a stop/start to read configuration changes, allowing this module to set an externally managed service thatcrayfishx-rsyslog
can notify on configuration changes is not only extremely helpful, but almost required.external_service
is a boolean that defaults tofalse
, MUST be used in conjunction withservice_name
, and CANNOT be used withmanage_service
.