Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

[request] Point to a secret key file instead of writing it in docker-compose.yml #18

Closed
zilexa opened this issue Apr 30, 2020 · 3 comments

Comments

@zilexa
Copy link

zilexa commented Apr 30, 2020

Currently the secret key itself needs to be given in an environmental variable.
Please allow the ability to link to a file instead, which should contain the secret key.

something like:

volumes: 
  - home/user/docker/firefox/secret:data/secret
@crazy-max
Copy link
Owner

Already available: https://github.com/crazy-max/docker-firefox-syncserver/blob/master/entrypoint.sh#L54

@zilexa
Copy link
Author

zilexa commented Apr 30, 2020

Oh that's great thank you!!

@zilexa
Copy link
Author

zilexa commented May 1, 2020

Pardon me for asking this, as I am already grateful for the image you have created.
I couldn't find more details in the documentation from Mozilla and as I am not a pro yet with Docker, one last question:
Can I just use .txt file extension or no extension at all? This is how I have set it up now:

    environment: 
      - PUID=${PUID}
      - PGID=${PGID}
      - TZ=${TZ}
      - FF_SYNCSERVER_PUBLIC_URL=https://firefox.mydomain.com
      - FF_SYNCSERVER_FORWARDED_ALLOW_IPS=*
      - FF_SYNCSERVER_SECRET_FILE=/data/secret/secret.txt
    volumes:
      - "${USERDIR}/docker/firefox-syncserver:/data"

and on the host the secret is in:
${USERDIR}/docker/firefox-syncserver/secret/secret.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants