Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 9P server support for libhvee #3870

Open
gbraad opened this issue Oct 16, 2023 · 5 comments
Open

Implement 9P server support for libhvee #3870

gbraad opened this issue Oct 16, 2023 · 5 comments

Comments

@gbraad
Copy link
Contributor

gbraad commented Oct 16, 2023

This is a follow-up to #3229, but will provide 9P support through the changes introduced by @mheon; via PR containers/gvisor-tap-vsock#280. They will be moved to another repo which allows us to re-use it via libhvee and CRC

@gbraad gbraad added kind/bug Something isn't working status/need triage labels Oct 16, 2023
@gbraad gbraad changed the title [BUG] [Spike] Implement 9P support for libhvee Oct 16, 2023
@gbraad gbraad added points/3 priority/major os/windows kind/spike Investigation to provide direction and workable tasks and removed kind/bug Something isn't working status/need triage labels Oct 16, 2023
@gbraad
Copy link
Contributor Author

gbraad commented Nov 29, 2023

Not a spike anymore as changes has been introduced to Podman's codebase

@gbraad gbraad added kind/task Workable task and removed kind/spike Investigation to provide direction and workable tasks labels Nov 29, 2023
@gbraad gbraad changed the title [Spike] Implement 9P support for libhvee Implement 9P support for libhvee Nov 29, 2023
@vyasgun
Copy link
Contributor

vyasgun commented Apr 19, 2024

@cfergeau Just had a chat with @gbraad and I will also be looking into this.

@cfergeau
Copy link
Contributor

9p server code from podman is easy to reuse in crc, even more so with these changes https://github.com/cfergeau/podman/tree/9p
Then with https://github.com/cfergeau/crc/blob/f698247126d89819638f6db4975c2e6397a5853d/cmd/crc/cmd/daemon.go#L203-L212 a 9p share is started at daemon startup time, and is reachable from the guest on 192.168.127.1 on port 564.

However the guest part is more problematic, while podman can use mount -t 9p ... to mount the share because it's using fedora, this is not working in our microshift/openshift images because they are RHEL-based, and don't provide support for 9p out of the box. As 9p support is getting more complicated than expected, imo we should be moving forward with #3824 without 9p support, and work on it as a follow-up.

@gbraad
Copy link
Contributor Author

gbraad commented May 15, 2024

we should be moving forward with #3824 without 9p support, and work on it as a follow-up.

Agree. I would even want to create a new issue for the 9P guest support.

@cfergeau cfergeau changed the title Implement 9P support for libhvee Implement 9P server support for libhvee May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Hold
Development

No branches or pull requests

3 participants