Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing QuerySetIsh removes a feature #47

Open
titusz opened this issue Dec 15, 2015 · 3 comments
Open

Removing QuerySetIsh removes a feature #47

titusz opened this issue Dec 15, 2015 · 3 comments

Comments

@titusz
Copy link

titusz commented Dec 15, 2015

I was updating to 0.6.0 and it broke due to the missing QuerySetIsh class. It might not be an obvious use case, but I am using QuerySetIsh with isinstance to determine if an action was called from the change list view or from the change form view. Now it seems to be impossible to find out how the action was called.

@crccheck
Copy link
Owner

Off the top of my head, we could:

  • change the decorator to pass in that information, but that changes the signature of things
  • monkey patch the queryset to have this information

any other ideas?

@titusz
Copy link
Author

titusz commented Dec 15, 2015

Hmmm. Maybe I can just skip using the decorator alltogether and simply check if queryset really is a QuerySet?

@crccheck
Copy link
Owner

you could. The logic is really simple now to turn the instance into a queryset. You could re-write just what you need for your version of Django.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants