Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GVK for listing CRDs in a repo #46

Closed
hasheddan opened this issue May 9, 2020 · 3 comments · Fixed by #62
Closed

Use GVK for listing CRDs in a repo #46

hasheddan opened this issue May 9, 2020 · 3 comments · Fixed by #62
Assignees

Comments

@hasheddan
Copy link
Member

CRDs are currently listed by filename. When controller-gen has generated the CRD files this works well as the pattern of the filename is <group>_<plural-kind>.yaml. However, it would be nice to also support files with arbitrary names and potentially present the CRDs in an organized format, such as nesting CRDs under their group and listing multiple versions of the same kind together.

@hasheddan
Copy link
Member Author

Fixed by #57

@mcristina422
Copy link

mcristina422 commented May 23, 2020

Would it also make sense to group by Group or GroupVersion? In the https://doc.crds.dev/github.com/jetstack/cert-manager view, having the acme.cert-manager.io/v1alpha2 Challenge and Order kinds next to each other would be preferable

@hasheddan
Copy link
Member Author

Good point @mcristina422! I’ll reopen this and make sure that gets updated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants