Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoInstance containerField holds field name for XML encoding #19

Closed
brutzman opened this issue Jul 10, 2017 · 3 comments
Closed

ProtoInstance containerField holds field name for XML encoding #19

brutzman opened this issue Jul 10, 2017 · 3 comments

Comments

@brutzman
Copy link

brutzman commented Jul 10, 2017

Incorrect construct for ProtoInstance containerField. See for example DLMF/21.4.F1a.x3d:

<Appearance > <texture><ProtoInstance name="pixelTexture_modlegend" ></ProtoInstance></texture> </Appearance>

should be

<Appearance > <ProtoInstance name="pixelTexture_modlegend" containerField='texture'/> </Appearance>

or, using equivalent paired open/close tags,

<Appearance > <ProtoInstance name="pixelTexture_modlegend" containerField='texture'></ProtoInstance> </Appearance>

etc.

@andreasplesch
Copy link

Could you enclose the xml in <> triple backticks to make those visible, please ? Thanks. Does the fixed example still work in cobweb ? If not, it would be great to file an issue with cobweb as well.

@andreasplesch
Copy link

Oh, well, from x3d-public:
example DLMF/21.4.F1a.x3d:

> <Appearance >
>      <texture><ProtoInstance name="pixelTexture_modlegend" ></ProtoInstance></texture>
> </Appearance>
>
> should be
>
> <Appearance >
>      <ProtoInstance name="pixelTexture_modlegend" containerField='texture'/>
> </Appearance>

@create3000
Copy link
Owner

Recent version of Titania will export valid XML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants