Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections should ignore type when comparing by value #114

Closed
Werebunny opened this issue Jan 31, 2024 · 0 comments · Fixed by #115
Closed

Collections should ignore type when comparing by value #114

Werebunny opened this issue Jan 31, 2024 · 0 comments · Fixed by #115
Assignees
Labels
bug Something isn't working

Comments

@Werebunny
Copy link
Member

Expected Behavior

Collections are equal by value based upon their contents.

Current Behavior

False when collections contain same data but are different collection types.

Possible Solution

Remove type check with collections.

Steps to Reproduce

  1. Create list of 1,2,3 and array of 1,2,3.
  2. Compare.

Additional Information

Add ability to enforce type comparison when doing #94.

@Werebunny Werebunny added the bug Something isn't working label Jan 31, 2024
@Werebunny Werebunny self-assigned this Jan 31, 2024
Werebunny added a commit that referenced this issue Jan 31, 2024
* Remove type enforcement for collections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant