Improve sed usage for performance #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 21, 2017
ljharb
force-pushed
the
performance-improvements-sed
branch
from
189fed8
to
6ed73b0
Compare
|
@PeterDaveHello could we use this opportunity to clean up a few more? I'm not super strong on my |
|
I'm not sure how many others can be improved right now, this could be the most easiest part I can improve right now. |
|
@ljharb I just look around and didn't see the same situation in this case, if you really need further optimization, it'll need to combine with other commands also, I think we can have that in another issue or PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.