Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Prevent install/link when no packages found #1750

Merged
merged 1 commit into from Mar 1, 2018
Merged

[Fix] Prevent install/link when no packages found #1750

merged 1 commit into from Mar 1, 2018

Conversation

PeterDaveHello
Copy link
Collaborator

@PeterDaveHello PeterDaveHello commented Feb 27, 2018 •
edited by ljharb

Fixes #1744.

@ljharb ljharb changed the title [Fix] Prevent install/link when no packages found, fix #1744 [Fix] Prevent install/link when no packages found Mar 1, 2018
ljharb
ljharb approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes and added a test. Will merge once it passes.

@ljharb ljharb force-pushed the fix-npm-pkg-reinstall branch 2 times, most recently from 8c88de3 to d6fa671 Compare March 1, 2018 07:55
@PeterDaveHello
Copy link
Collaborator Author

Thanks

@ljharb ljharb merged commit d6fa671 into nvm-sh:master Mar 1, 2018
@PeterDaveHello PeterDaveHello deleted the fix-npm-pkg-reinstall branch March 2, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterDaveHello @ljharb