[shellcheck] update dockerfile to shellcheck v0.6.0

[sturman]

No description provided.

[ljharb]

Hmm, this should be failing tests, since there's still one more category of shellcheck checks that aren't passing on master.

[ljharb]

@PeterDaveHello any idea why these tests are passing, when I get this output locally?:

[Jordans-MacBook-Pro .nvm ((eabd7ab...)) v10.4.1 (1)]$ shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh

In nvm.sh line 53:
    INFO="$(which "${COMMAND}") ($(type "${COMMAND}" | command awk '{ $1=$2=$3=$4="" ;print }' | command sed -e 's/^\ *//g' -Ee "s/\`|'//g" ))"
            ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.


In nvm.sh line 55:
    INFO="$(which "${COMMAND}") ($(type "${COMMAND}" | command awk '{ $1=$2=$3=$4=$5="" ;print }' | command sed 's/^\ *//g'))"
            ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.

$ shellcheck -s ksh nvm.sh && shellcheck -s bash install.sh bash_completion nvm-exec

In nvm.sh line 53:
    INFO="$(which "${COMMAND}") ($(type "${COMMAND}" | command awk '{ $1=$2=$3=$4="" ;print }' | command sed -e 's/^\ *//g' -Ee "s/\`|'//g" ))"
            ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.


In nvm.sh line 55:
    INFO="$(which "${COMMAND}") ($(type "${COMMAND}" | command awk '{ $1=$2=$3=$4=$5="" ;print }' | command sed 's/^\ *//g'))"
            ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.

[ljharb]

ah, just figured it out :-) you only updated the dockerfile, and travis-ci must still be on 0.4.7.

I'm going to keep this open until the 0.5.0 issues are resolved.

[sturman]

Updated shellcheck to v0.5.0 on Travis-CI. There is the same failed job as in #1836 (comment) on Travis-CI build

[PeterDaveHello]

I wonder if we should manually install the latest version or try to confirm/push Travis CI to update it? Their script was updated to fetch the latest version, maybe just need a small release to reflect that.

[ljharb]

I appreciate the expected failure here, but i agree - we should wait until travis has updated itself (which will happen on their next worker deploy).

[ljharb]

locally, shellcheck is on v0.7.0; in travis it's v0.6.0.

I don't think this change is particularly needed anymore.