Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Posts Redesign Bug #764

Closed
wants to merge 2 commits into from
Closed

Conversation

Kirsty21
Copy link
Contributor

Fixes

I made some changes to the stylesheet. These include:

  • Removing the recent posts background color to white
  • Adding color to the article containers instead
  • Reducing the size of the article headings to 1.3em, and centering them
  • Reducing the thickness of the border around the avatar images to 0.1em instead
  • Adding a faint box shadow that give the article areas some dimension
  • And so on

Fixes #761] by @[Kirsty21]

Description

Recent posts section of page redesign

Technical details

These changes were on applied to screen sizes greater than 768px as the mobile was not my target area

Tests

Changes were made via the development environment in the file 'style.css' in the folder 'static'. I've commented the section that I made changes to. You can search Kirsty21 GSOC24'

Screenshots

Before:
image

After:
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Kirsty21 Kirsty21 requested review from a team as code owners February 29, 2024 15:50
@Kirsty21 Kirsty21 requested review from Shafiya-Heena, possumbilities and akmadian and removed request for a team February 29, 2024 15:50
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Feb 29, 2024
@possumbilities
Copy link
Contributor

Hi @Kirsty21 this is for an Issue that did not move to status: ready for work I'm closing it. I would strongly suggest offering up proposals for the design in the original Issue, with details, and justifications for the changes, and how they related to and support the current visual system that the rest of the site currently follows.

Please review the Contribution Guidelines.

Active Sprint automation moved this from Code Review to Done Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Done
Development

Successfully merging this pull request may close these issues.

[Feature] Recent Posts Design
2 participants