Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialized i18n and added Spanish support to cases page #100

Closed
wants to merge 6 commits into from
Closed

Initialized i18n and added Spanish support to cases page #100

wants to merge 6 commits into from

Conversation

darkshredder
Copy link
Contributor

@darkshredder darkshredder commented Feb 19, 2021 •
edited by TimidRobot
Loading

Feature

Description

This pull request initializes the support of i18n for internationalization and localization of our application. It has also added support of spanish language in cases page of the project.

Tests

  • Install firefox extensions like Language Switch where we can switch between languages of our visiting page.

  • Using it on /cases url and switching to spanish.

  • We can see spanish is written on that page

Screenshots

Screenshot_2021-02-20 CC Legal Database

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@darkshredder darkshredder requested a review from a team as a code owner February 19, 2021 23:33
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Feb 19, 2021
@darkshredder darkshredder changed the title Initialized i18n and added spanish support to cases page Initialized i18n and added Spanish support to cases page Feb 19, 2021
avats-dev
avats-dev reviewed Feb 20, 2021
View reviewed changes
caselaw/settings.py Outdated Show resolved Hide resolved
TimidRobot
TimidRobot requested changes May 13, 2021
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update README with instructions (reference upstream documentation where possible) for generating and managing translations.

caselaw/settings.py
@@ -52,6 +52,7 @@
# SecurityMiddleware must be listed before other middleware
"django.middleware.security.SecurityMiddleware",
"django.contrib.sessions.middleware.SessionMiddleware",
"django.middleware.locale.LocaleMiddleware",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to indicate position. Something like:

   # LocaleMiddleware should be listed after SessionMiddleware, but before CommonMiddleware

legal_db/locale/es/LC_MESSAGES/django.po
Comment on lines +1 to +19
# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
#
#, fuzzy
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2021-02-20 04:44+0530\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1);\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update / fill in the metadata

@TimidRobot TimidRobot self-assigned this May 13, 2021
@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Apr 9, 2024
@TimidRobot TimidRobot closed this Apr 9, 2024
Active Sprint automation moved this from Code Review to Done Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avats-dev avats-dev avats-dev left review comments

@TimidRobot TimidRobot TimidRobot requested changes

Assignees

@TimidRobot TimidRobot

Labels
⛔️ status: discarded Will not be worked on
Projects
Active Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding i18n Support
3 participants
@darkshredder @TimidRobot @avats-dev