Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interpretation of root and workspace params in email templates #3

Closed
michael-e opened this issue Dec 22, 2011 · 6 comments
Closed
Assignees

Comments

@michael-e
Copy link
Owner

Posted on the Symphony website (by Komb):

Root solves to "http://hostname/var/www/blah/blah/emailnewslettermanager/lib/" Workspace behaves the same, but with added workspace folder of course.

Very bad for building absolute image paths and such.

@michael-e
Copy link
Owner Author

This is not related to ENM but to the ETM (Email Template Manager). I will close the issue here and post it over there.

@michael-e
Copy link
Owner Author

@creativedutchmen
Copy link
Collaborator

Oh yes this is an ENM bug alright. The reason for this is that the background process is not an apache process, so the DocumentRoot variable does not make sense to it. Will fix!

@michael-e
Copy link
Owner Author

Any news on this? It's a bit of a showstopper for me at the moment.

Or is there a workaround I don't think of?

@michael-e
Copy link
Owner Author

For now I worked around this by adding another datasource which contains the root param's value.

@michael-e
Copy link
Owner Author

I thought about this a bit more. Symphony can run on several domains, so the only safe solution would be to pass the domain with the ENM's API call and save it to the newsletter table. (The deprecated Email Newsletters extension did exactly this.)

If it's about images, you can add a hardcoded $root-email parameter to your email templates and work with that. The real problem I see will be authors who have been told to use links like the following when writing in Symphony:

[visit our contact page](/contact/)

This, of course, won't work with a "universal image domain" if your Symphony website delivers content based on the domain name.

I may address this when all the other bugs are fixed. I'd like to know if anybody has a better idea than the one I outlined above.

@ghost ghost assigned michael-e May 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants